From 2fd8d0466e3035e587fda46cf23b525ccf6d8dd3 Mon Sep 17 00:00:00 2001
From: Arnaud Levy <contact@arnaudlevy.com>
Date: Thu, 19 Jan 2023 17:28:39 +0100
Subject: [PATCH] tests

---
 app/models/research/journal/paper.rb          |  3 ++
 .../journal/paper/kinds_controller_test.rb    | 48 -------------------
 .../fixtures/research/journal/paper/kinds.yml | 12 +++--
 test/fixtures/research/journals.yml           |  3 ++
 4 files changed, 14 insertions(+), 52 deletions(-)
 delete mode 100644 test/controllers/research/journal/paper/kinds_controller_test.rb
 create mode 100644 test/fixtures/research/journals.yml

diff --git a/app/models/research/journal/paper.rb b/app/models/research/journal/paper.rb
index 01e528a3e..9858a524f 100644
--- a/app/models/research/journal/paper.rb
+++ b/app/models/research/journal/paper.rb
@@ -16,6 +16,7 @@
 #  title                      :string
 #  created_at                 :datetime         not null
 #  updated_at                 :datetime         not null
+#  paper_kind_id              :uuid             indexed
 #  research_journal_id        :uuid             not null, indexed
 #  research_journal_volume_id :uuid             indexed
 #  university_id              :uuid             not null, indexed
@@ -23,6 +24,7 @@
 #
 # Indexes
 #
+#  index_research_journal_papers_on_paper_kind_id               (paper_kind_id)
 #  index_research_journal_papers_on_research_journal_id         (research_journal_id)
 #  index_research_journal_papers_on_research_journal_volume_id  (research_journal_volume_id)
 #  index_research_journal_papers_on_university_id               (university_id)
@@ -34,6 +36,7 @@
 #  fk_rails_22f161a6a7  (research_journal_volume_id => research_journal_volumes.id)
 #  fk_rails_2713063b85  (updated_by_id => users.id)
 #  fk_rails_935541e014  (university_id => universities.id)
+#  fk_rails_db4e38788c  (paper_kind_id => research_journal_paper_kinds.id)
 #
 class Research::Journal::Paper < ApplicationRecord
   include Sanitizable
diff --git a/test/controllers/research/journal/paper/kinds_controller_test.rb b/test/controllers/research/journal/paper/kinds_controller_test.rb
deleted file mode 100644
index 1a04c1f06..000000000
--- a/test/controllers/research/journal/paper/kinds_controller_test.rb
+++ /dev/null
@@ -1,48 +0,0 @@
-require "test_helper"
-
-class Research::Journal::Paper::KindsControllerTest < ActionDispatch::IntegrationTest
-  setup do
-    @research_journal_paper_kind = research_journal_paper_kinds(:one)
-  end
-
-  test "should get index" do
-    get research_journal_paper_kinds_url
-    assert_response :success
-  end
-
-  test "should get new" do
-    get new_research_journal_paper_kind_url
-    assert_response :success
-  end
-
-  test "should create research_journal_paper_kind" do
-    assert_difference("Research::Journal::Paper::Kind.count") do
-      post research_journal_paper_kinds_url, params: { research_journal_paper_kind: { slug: @research_journal_paper_kind.slug, title: @research_journal_paper_kind.title } }
-    end
-
-    assert_redirected_to research_journal_paper_kind_url(Research::Journal::Paper::Kind.last)
-  end
-
-  test "should show research_journal_paper_kind" do
-    get research_journal_paper_kind_url(@research_journal_paper_kind)
-    assert_response :success
-  end
-
-  test "should get edit" do
-    get edit_research_journal_paper_kind_url(@research_journal_paper_kind)
-    assert_response :success
-  end
-
-  test "should update research_journal_paper_kind" do
-    patch research_journal_paper_kind_url(@research_journal_paper_kind), params: { research_journal_paper_kind: { slug: @research_journal_paper_kind.slug, title: @research_journal_paper_kind.title } }
-    assert_redirected_to research_journal_paper_kind_url(@research_journal_paper_kind)
-  end
-
-  test "should destroy research_journal_paper_kind" do
-    assert_difference("Research::Journal::Paper::Kind.count", -1) do
-      delete research_journal_paper_kind_url(@research_journal_paper_kind)
-    end
-
-    assert_redirected_to research_journal_paper_kinds_url
-  end
-end
diff --git a/test/fixtures/research/journal/paper/kinds.yml b/test/fixtures/research/journal/paper/kinds.yml
index 72d656d1d..70e0e791d 100644
--- a/test/fixtures/research/journal/paper/kinds.yml
+++ b/test/fixtures/research/journal/paper/kinds.yml
@@ -22,9 +22,13 @@
 #
 
 one:
-  title: MyString
-  slug: MyString
+  university: default_university
+  journal: default_journal
+  title: Articles
+  slug: articles
 
 two:
-  title: MyString
-  slug: MyString
+  university: default_university
+  journal: default_journal
+  title: Recensions
+  slug: recensions
diff --git a/test/fixtures/research/journals.yml b/test/fixtures/research/journals.yml
new file mode 100644
index 000000000..763bdc842
--- /dev/null
+++ b/test/fixtures/research/journals.yml
@@ -0,0 +1,3 @@
+default_journal:
+  university: default_university
+  title: Journal
-- 
GitLab