From 4b6168a999f6b967e6d9155072b90309016b0399 Mon Sep 17 00:00:00 2001
From: Arnaud Levy <contact@arnaudlevy.com>
Date: Mon, 2 Jan 2023 13:55:22 +0100
Subject: [PATCH] refactor

---
 app/services/blocks_migration.rb | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/app/services/blocks_migration.rb b/app/services/blocks_migration.rb
index c8d25e13b..ea141cfd2 100644
--- a/app/services/blocks_migration.rb
+++ b/app/services/blocks_migration.rb
@@ -7,14 +7,13 @@ class BlocksMigration
     Communication::Website::Post.find_each do |post|
       next if post.text.blank?
       puts "#{post} (#{post.id}, #{post.university})"
-      if post.blocks.none?
-        puts "  migrating"
-        block = post.blocks.create university: post.university, template_kind: :chapter
-        data = block.data
-        data['text'] = post.text.to_html
-        block.data = data
-        block.save
-      end
+      next if post.blocks.any?
+      puts "  migrating"
+      block = post.blocks.create university: post.university, template_kind: :chapter
+      data = block.data
+      data['text'] = post.text.to_html
+      block.data = data
+      block.save
     end
   end
 end
-- 
GitLab