From 7373ed4d73318ca9268cebef2f4184cff36b59ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Gaya?= <sebastien.gaya@gmail.com>
Date: Mon, 9 Jan 2023 01:19:03 +0100
Subject: [PATCH] wip tests
---
Gemfile | 3 +-
Gemfile.lock | 3 +-
test/controllers/.keep | 0
.../academic_years_controller_test.rb | 18 ++++
.../extranet/account_controller_test.rb | 30 +++++++
.../extranet/cohorts_controller_test.rb | 18 ++++
.../extranet/experiences_controller_test.rb | 46 ++++++++++
.../extranet/home_controller_test.rb | 22 +++++
.../extranet/organizations_controller_test.rb | 26 ++++++
.../extranet/pages_controller_test.rb | 28 +++++++
.../extranet/personal_data_controller_test.rb | 25 ++++++
.../extranet/persons_controller_test.rb | 18 ++++
test/fixtures/communication/extranets.yml | 14 ++--
test/fixtures/education/academic_years.yml | 4 +-
test/fixtures/education/cohorts.yml | 15 +---
test/fixtures/education/diplomas.yml | 15 +---
test/fixtures/education/programs.yml | 59 +++++++++++++
test/fixtures/education/schools.yml | 6 +-
test/fixtures/university/organizations.yml | 33 +-------
test/fixtures/university/people.yml | 58 +++++++++++++
.../university/person/experiences.yml | 33 ++++++++
test/fixtures/users.yml | 84 +++++++++++++++++++
test/test_helper.rb | 20 ++++-
23 files changed, 511 insertions(+), 67 deletions(-)
delete mode 100644 test/controllers/.keep
create mode 100644 test/controllers/extranet/academic_years_controller_test.rb
create mode 100644 test/controllers/extranet/account_controller_test.rb
create mode 100644 test/controllers/extranet/cohorts_controller_test.rb
create mode 100644 test/controllers/extranet/experiences_controller_test.rb
create mode 100644 test/controllers/extranet/home_controller_test.rb
create mode 100644 test/controllers/extranet/organizations_controller_test.rb
create mode 100644 test/controllers/extranet/pages_controller_test.rb
create mode 100644 test/controllers/extranet/personal_data_controller_test.rb
create mode 100644 test/controllers/extranet/persons_controller_test.rb
create mode 100644 test/fixtures/education/programs.yml
create mode 100644 test/fixtures/university/people.yml
create mode 100644 test/fixtures/university/person/experiences.yml
create mode 100644 test/fixtures/users.yml
diff --git a/Gemfile b/Gemfile
index df6f772a1..6b135e110 100644
--- a/Gemfile
+++ b/Gemfile
@@ -56,7 +56,8 @@ gem "simple_form_password_with_hints"#, path: "../simple_form_password_with_hint
gem "sprockets-rails", "~> 3.4"
gem "summernote-rails", git: "https://github.com/noesya/summernote-rails.git", branch: "activestorage"
# gem "summernote-rails", path: "../summernote-rails"
-gem "two_factor_authentication", git: "https://github.com/noesya/two_factor_authentication.git"
+# gem "two_factor_authentication", git: "https://github.com/noesya/two_factor_authentication.git"
+gem "two_factor_authentication", git: "https://github.com/noesya/two_factor_authentication.git", ref: "feature/integration-helper"
# gem "two_factor_authentication", path: "../two_factor_authentication"
gem "unsplash"
diff --git a/Gemfile.lock b/Gemfile.lock
index 7bc762f5d..a5e6ea852 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -9,7 +9,8 @@ GIT
GIT
remote: https://github.com/noesya/two_factor_authentication.git
- revision: 4574ece65da41397dd852001e22a0c3b9ee3d01e
+ revision: b2d59800e77bd1a92fe9a95b047dcc4213d590df
+ ref: feature/integration-helper
specs:
two_factor_authentication (4.0.0)
devise
diff --git a/test/controllers/.keep b/test/controllers/.keep
deleted file mode 100644
index e69de29bb..000000000
diff --git a/test/controllers/extranet/academic_years_controller_test.rb b/test/controllers/extranet/academic_years_controller_test.rb
new file mode 100644
index 000000000..8ed78fbb4
--- /dev/null
+++ b/test/controllers/extranet/academic_years_controller_test.rb
@@ -0,0 +1,18 @@
+require "test_helper"
+
+class Extranet::AcademicYearsControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_index
+ get education_academic_years_path
+ assert_response(:success)
+ end
+
+ def test_show
+ get education_academic_year_path(education_academic_years(:twenty_two))
+ assert_response(:success)
+ end
+end
diff --git a/test/controllers/extranet/account_controller_test.rb b/test/controllers/extranet/account_controller_test.rb
new file mode 100644
index 000000000..9f82279c9
--- /dev/null
+++ b/test/controllers/extranet/account_controller_test.rb
@@ -0,0 +1,30 @@
+require "test_helper"
+
+class Extranet::AccountControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_show
+ get account_path
+ assert_response(:success)
+ end
+
+ def test_edit
+ get edit_account_path
+ assert_response(:success)
+ end
+
+ def test_update
+ assert_equal("Alumnus", alumnus.first_name)
+ patch account_path, params: { user: { first_name: "New Alumnus" } }
+ assert_redirected_to(account_path)
+ assert_equal("New Alumnus", alumnus.first_name)
+ end
+
+ def test_update_password
+ patch account_path, params: { user: { password: "NewPassw0rd!" } }
+ assert_redirected_to(account_path)
+ end
+end
diff --git a/test/controllers/extranet/cohorts_controller_test.rb b/test/controllers/extranet/cohorts_controller_test.rb
new file mode 100644
index 000000000..ec02f3b43
--- /dev/null
+++ b/test/controllers/extranet/cohorts_controller_test.rb
@@ -0,0 +1,18 @@
+require "test_helper"
+
+class Extranet::CohortsControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_index
+ get education_cohorts_path
+ assert_response(:success)
+ end
+
+ def test_show
+ get education_cohort_path(education_cohorts(:default_cohort))
+ assert_response(:success)
+ end
+end
diff --git a/test/controllers/extranet/experiences_controller_test.rb b/test/controllers/extranet/experiences_controller_test.rb
new file mode 100644
index 000000000..53ba2357d
--- /dev/null
+++ b/test/controllers/extranet/experiences_controller_test.rb
@@ -0,0 +1,46 @@
+require "test_helper"
+
+class Extranet::ExperiencesControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_new
+ get new_experience_path
+ assert_response(:success)
+ end
+
+ def test_create
+ assert_difference("alumnus.experiences.count") do
+ post experiences_path, params: {
+ university_person_experience: {
+ description: "Stage",
+ from_year: 2022,
+ to_year: 2022,
+ organization_id: university_organizations(:default_organization).id
+ }
+ }
+ assert_redirected_to(account_path)
+ end
+ end
+
+ def test_edit
+ get edit_experience_path(university_person_experiences(:default_experience))
+ assert_response(:success)
+ end
+
+ def test_update
+ experience = university_person_experiences(:default_experience)
+
+ assert(experience.description.blank?)
+ patch experience_path(experience), params: {
+ university_person_experience: {
+ description: "Alternance"
+ }
+ }
+ assert_redirected_to(account_path)
+ assert_equal("Alternance", experience.reload.description)
+ end
+
+end
diff --git a/test/controllers/extranet/home_controller_test.rb b/test/controllers/extranet/home_controller_test.rb
new file mode 100644
index 000000000..c0ce63386
--- /dev/null
+++ b/test/controllers/extranet/home_controller_test.rb
@@ -0,0 +1,22 @@
+require "test_helper"
+
+class Extranet::HomeControllerTest < ActionDispatch::IntegrationTest
+
+ def test_index_unknown_context
+ get(root_path)
+ assert_response(:forbidden)
+ end
+
+ def test_index_unauthenticated
+ host! "extranet.osuny"
+ get(root_path)
+ assert_redirected_to(new_user_session_path)
+ end
+
+ def test_index
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ get(root_path)
+ assert_response(:success)
+ end
+end
diff --git a/test/controllers/extranet/organizations_controller_test.rb b/test/controllers/extranet/organizations_controller_test.rb
new file mode 100644
index 000000000..7ae1d867c
--- /dev/null
+++ b/test/controllers/extranet/organizations_controller_test.rb
@@ -0,0 +1,26 @@
+require "test_helper"
+
+class Extranet::OrganizationsControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_index
+ get university_organizations_path
+ assert_response(:success)
+ end
+
+ def test_search
+ get search_university_organizations_path(term: "Organisation de test")
+ assert_response(:success)
+ results = JSON.parse(response.body)
+ assert_equal(1, results.size)
+ assert_equal("Organisation de test", results.first["label"])
+ end
+
+ def test_show
+ get university_organization_path(university_organizations(:default_organization))
+ assert_response(:success)
+ end
+end
diff --git a/test/controllers/extranet/pages_controller_test.rb b/test/controllers/extranet/pages_controller_test.rb
new file mode 100644
index 000000000..744fb30d5
--- /dev/null
+++ b/test/controllers/extranet/pages_controller_test.rb
@@ -0,0 +1,28 @@
+require "test_helper"
+
+class Extranet::PagesControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_terms
+ get terms_path
+ assert_response(:success)
+ end
+
+ def test_cookies_policy
+ get cookies_policy_path
+ assert_response(:success)
+ end
+
+ def test_privacy_policy
+ get privacy_policy_path
+ assert_response(:success)
+ end
+
+ def test_data
+ get data_path
+ assert_response(:success)
+ end
+end
diff --git a/test/controllers/extranet/personal_data_controller_test.rb b/test/controllers/extranet/personal_data_controller_test.rb
new file mode 100644
index 000000000..32ae5db3e
--- /dev/null
+++ b/test/controllers/extranet/personal_data_controller_test.rb
@@ -0,0 +1,25 @@
+require "test_helper"
+
+class Extranet::PersonalDataControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_edit
+ get edit_personal_data_path
+ assert_response(:success)
+ end
+
+ def test_update
+ assert(alumnus_person.biography.blank?)
+ patch personal_data_path, params: { university_person: { biography: "<p>Je suis un ancien étudiant.</p>" } }
+ assert_redirected_to(account_path)
+ assert(alumnus_person.reload.biography.to_s.include?("Je suis un ancien étudiant."))
+ end
+
+ def test_update_invalid
+ patch personal_data_path, params: { university_person: { last_name: "" } }
+ assert_response(:unprocessable_entity)
+ end
+end
diff --git a/test/controllers/extranet/persons_controller_test.rb b/test/controllers/extranet/persons_controller_test.rb
new file mode 100644
index 000000000..1de67c12e
--- /dev/null
+++ b/test/controllers/extranet/persons_controller_test.rb
@@ -0,0 +1,18 @@
+require "test_helper"
+
+class Extranet::PersonsControllerTest < ActionDispatch::IntegrationTest
+ def setup
+ host! "extranet.osuny"
+ sign_in_with_2fa(alumnus)
+ end
+
+ def test_index
+ get university_persons_path
+ assert_response(:success)
+ end
+
+ def test_show
+ get university_person_path(university_people(:alumnus))
+ assert_response(:success)
+ end
+end
diff --git a/test/fixtures/communication/extranets.yml b/test/fixtures/communication/extranets.yml
index fa530b05d..b302abd99 100644
--- a/test/fixtures/communication/extranets.yml
+++ b/test/fixtures/communication/extranets.yml
@@ -33,12 +33,8 @@
# fk_rails_c2268c7ebd (university_id => universities.id)
#
-one:
- name: MyString
- university: default_university
- host: MyString
-
-two:
- name: MyString
- university: default_university
- host: MyString
+default_extranet:
+ name: Extranet de test
+ host: extranet.osuny
+ about: default_program (Education::Program)
+ university: default_university
\ No newline at end of file
diff --git a/test/fixtures/education/academic_years.yml b/test/fixtures/education/academic_years.yml
index ede802b52..569a5d2a1 100644
--- a/test/fixtures/education/academic_years.yml
+++ b/test/fixtures/education/academic_years.yml
@@ -17,10 +17,10 @@
# fk_rails_7d376afe35 (university_id => universities.id)
#
-one:
+twenty_two:
university: default_university
year: 2022
-two:
+twenty_three:
university: default_university
year: 2023
diff --git a/test/fixtures/education/cohorts.yml b/test/fixtures/education/cohorts.yml
index 9299e067d..7e9d752e8 100644
--- a/test/fixtures/education/cohorts.yml
+++ b/test/fixtures/education/cohorts.yml
@@ -26,16 +26,9 @@
# fk_rails_c2d725cabd (academic_year_id => education_academic_years.id)
#
-one:
+default_cohort:
+ name: Formation de test 2022
university: default_university
school: default_school
- program: one
- academic_year: one
- name: MyString
-
-two:
- university: default_university
- school: default_school
- program: two
- academic_year: two
- name: MyString
+ program: default_program
+ academic_year: twenty_two
diff --git a/test/fixtures/education/diplomas.yml b/test/fixtures/education/diplomas.yml
index 7116f2153..24714a0e3 100644
--- a/test/fixtures/education/diplomas.yml
+++ b/test/fixtures/education/diplomas.yml
@@ -23,16 +23,7 @@
# fk_rails_6cb2e9fa90 (university_id => universities.id)
#
-one:
+default_diploma:
+ name: Diplôme de test
+ short_name: DT
university: default_university
- name: MyString
- short_name: MyString
- level: 1
- slug: MyString
-
-two:
- university: default_university
- name: MyString
- short_name: MyString
- level: 1
- slug: MyString
diff --git a/test/fixtures/education/programs.yml b/test/fixtures/education/programs.yml
new file mode 100644
index 000000000..d44de7e29
--- /dev/null
+++ b/test/fixtures/education/programs.yml
@@ -0,0 +1,59 @@
+# == Schema Information
+#
+# Table name: education_programs
+#
+# id :uuid not null, primary key
+# accessibility :text
+# apprenticeship :boolean
+# capacity :integer
+# contacts :text
+# content :text
+# continuing :boolean
+# description :text
+# description_short :text
+# duration :text
+# evaluation :text
+# featured_image_alt :string
+# featured_image_credit :text
+# initial :boolean
+# name :string
+# objectives :text
+# opportunities :text
+# other :text
+# path :string
+# pedagogy :text
+# position :integer default(0)
+# prerequisites :text
+# presentation :text
+# pricing :text
+# published :boolean default(FALSE)
+# registration :text
+# registration_url :string
+# results :text
+# short_name :string
+# slug :string
+# created_at :datetime not null
+# updated_at :datetime not null
+# diploma_id :uuid indexed
+# parent_id :uuid indexed
+# university_id :uuid not null, indexed
+#
+# Indexes
+#
+# index_education_programs_on_diploma_id (diploma_id)
+# index_education_programs_on_parent_id (parent_id)
+# index_education_programs_on_university_id (university_id)
+#
+# Foreign Keys
+#
+# fk_rails_08b351087c (university_id => universities.id)
+# fk_rails_ec1f16f607 (parent_id => education_programs.id)
+#
+
+default_program:
+ name: Formation de test
+ published: true
+ diploma: default_diploma
+ schools:
+ - default_school
+ university: default_university
diff --git a/test/fixtures/education/schools.yml b/test/fixtures/education/schools.yml
index c8a131ca1..e0f957684 100644
--- a/test/fixtures/education/schools.yml
+++ b/test/fixtures/education/schools.yml
@@ -25,4 +25,8 @@
#
default_school:
name: École de test
- university: default_university
+ address: 1 Rue Jacques Ellul
+ zipcode: 33080
+ city: Bordeaux
+ country: FR
+ university: default_university
\ No newline at end of file
diff --git a/test/fixtures/university/organizations.yml b/test/fixtures/university/organizations.yml
index 664399044..a69b18fb2 100644
--- a/test/fixtures/university/organizations.yml
+++ b/test/fixtures/university/organizations.yml
@@ -33,32 +33,7 @@
# fk_rails_35fcd198e0 (university_id => universities.id)
#
-one:
- university: default_university
- name: MyString
- description: MyText
- address: MyString
- zipcode: MyString
- city: MyString
- country: MyString
- url: MyString
- phone: MyString
- email: MyString
- active: false
- siren: MyString
- kind: 1
-
-two:
- university: default_university
- name: MyString
- description: MyText
- address: MyString
- zipcode: MyString
- city: MyString
- country: MyString
- url: MyString
- phone: MyString
- email: MyString
- active: false
- siren: MyString
- kind: 1
+default_organization:
+ name: Organisation de test
+ active: true
+ university: default_university
\ No newline at end of file
diff --git a/test/fixtures/university/people.yml b/test/fixtures/university/people.yml
new file mode 100644
index 000000000..2281277b1
--- /dev/null
+++ b/test/fixtures/university/people.yml
@@ -0,0 +1,58 @@
+# == Schema Information
+#
+# Table name: university_people
+#
+# id :uuid not null, primary key
+# address :string
+# biography :text
+# birthdate :date
+# city :string
+# country :string
+# description :text
+# description_short :text
+# email :string
+# first_name :string
+# gender :integer
+# habilitation :boolean default(FALSE)
+# is_administration :boolean
+# is_alumnus :boolean default(FALSE)
+# is_author :boolean
+# is_researcher :boolean
+# is_teacher :boolean
+# last_name :string
+# linkedin :string
+# name :string
+# phone_mobile :string
+# phone_personal :string
+# phone_professional :string
+# slug :string
+# tenure :boolean default(FALSE)
+# twitter :string
+# url :string
+# zipcode :string
+# created_at :datetime not null
+# updated_at :datetime not null
+# university_id :uuid not null, indexed
+# user_id :uuid indexed
+#
+# Indexes
+#
+# index_university_people_on_university_id (university_id)
+# index_university_people_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_b47a769440 (user_id => users.id)
+# fk_rails_da35e70d61 (university_id => universities.id)
+#
+
+alumnus:
+ email: alumnus@osuny.org
+ first_name: Alumnus
+ is_alumnus: true
+ last_name: Osuny
+ name: Alumnus Osuny
+ cohorts:
+ - default_cohort
+ university: default_university
+ user: alumnus
\ No newline at end of file
diff --git a/test/fixtures/university/person/experiences.yml b/test/fixtures/university/person/experiences.yml
new file mode 100644
index 000000000..8aa8f8850
--- /dev/null
+++ b/test/fixtures/university/person/experiences.yml
@@ -0,0 +1,33 @@
+# == Schema Information
+#
+# Table name: university_person_experiences
+#
+# id :uuid not null, primary key
+# description :text
+# from_year :integer
+# to_year :integer
+# created_at :datetime not null
+# updated_at :datetime not null
+# organization_id :uuid not null, indexed
+# person_id :uuid not null, indexed
+# university_id :uuid not null, indexed
+#
+# Indexes
+#
+# index_university_person_experiences_on_organization_id (organization_id)
+# index_university_person_experiences_on_person_id (person_id)
+# index_university_person_experiences_on_university_id (university_id)
+#
+# Foreign Keys
+#
+# fk_rails_18125d90df (person_id => university_people.id)
+# fk_rails_38aaa18a3b (organization_id => university_organizations.id)
+# fk_rails_923d0b71fd (university_id => universities.id)
+#
+
+default_experience:
+ from_year: 2022
+ to_year: 2023
+ person: alumnus
+ organization: default_organization
+ university: default_university
\ No newline at end of file
diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml
new file mode 100644
index 000000000..a830b4a70
--- /dev/null
+++ b/test/fixtures/users.yml
@@ -0,0 +1,84 @@
+# == Schema Information
+#
+# Table name: users
+#
+# id :uuid not null, primary key
+# admin_theme :integer default("appstack")
+# confirmation_sent_at :datetime
+# confirmation_token :string indexed
+# confirmed_at :datetime
+# current_sign_in_at :datetime
+# current_sign_in_ip :string
+# direct_otp :string
+# direct_otp_delivery_method :string
+# direct_otp_sent_at :datetime
+# email :string default(""), not null, indexed => [university_id]
+# encrypted_otp_secret_key :string indexed
+# encrypted_otp_secret_key_iv :string
+# encrypted_otp_secret_key_salt :string
+# encrypted_password :string default(""), not null
+# failed_attempts :integer default(0), not null
+# first_name :string
+# last_name :string
+# last_sign_in_at :datetime
+# last_sign_in_ip :string
+# locked_at :datetime
+# mobile_phone :string
+# picture_url :string
+# remember_created_at :datetime
+# reset_password_sent_at :datetime
+# reset_password_token :string indexed
+# role :integer default("visitor")
+# second_factor_attempts_count :integer default(0)
+# session_token :string
+# sign_in_count :integer default(0), not null
+# totp_timestamp :datetime
+# unconfirmed_email :string
+# unlock_token :string indexed
+# created_at :datetime not null
+# updated_at :datetime not null
+# language_id :uuid indexed
+# university_id :uuid not null, indexed => [email], indexed
+#
+# Indexes
+#
+# index_users_on_confirmation_token (confirmation_token) UNIQUE
+# index_users_on_email_and_university_id (email,university_id) UNIQUE
+# index_users_on_encrypted_otp_secret_key (encrypted_otp_secret_key) UNIQUE
+# index_users_on_language_id (language_id)
+# index_users_on_reset_password_token (reset_password_token) UNIQUE
+# index_users_on_university_id (university_id)
+# index_users_on_unlock_token (unlock_token) UNIQUE
+#
+# Foreign Keys
+#
+# fk_rails_45f4f12508 (language_id => languages.id)
+# fk_rails_bd6f7212a9 (university_id => universities.id)
+#
+
+alumnus:
+ confirmed_at: <%= Time.zone.now %>
+ email: alumnus@osuny.org
+ first_name: Alumnus
+ last_name: Osuny
+ role: user
+ language: fr
+ university: default_university
+
+admin:
+ confirmed_at: <%= Time.zone.now %>
+ email: admin@osuny.org
+ first_name: Admin
+ last_name: Osuny
+ role: admin
+ language: fr
+ university: default_university
+
+server_admin:
+ confirmed_at: <%= Time.zone.now %>
+ email: serveradmin@osuny.org
+ first_name: Server Admin
+ last_name: Osuny
+ role: server_admin
+ language: fr
+ university: default_university
\ No newline at end of file
diff --git a/test/test_helper.rb b/test/test_helper.rb
index 35caf4585..9767cbaf9 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -8,6 +8,24 @@ require "rails/test_help"
Dir["./test/support/**/*.rb"].each { |f| require f }
class ActiveSupport::TestCase
- parallelize(workers: :number_of_processors)
+ include Devise::Test::IntegrationHelpers
+ include TwoFactorAuthentication::Test::IntegrationHelpers
+
fixtures :all
+
+ def alumnus
+ @alumnus ||= users(:alumnus)
+ end
+
+ def alumnus_person
+ @alumnus_person ||= university_people(:alumnus)
+ end
+
+ def admin
+ @admin ||= users(:admin)
+ end
+
+ def server_admin
+ @server_admin ||= users(:server_admin)
+ end
end
--
GitLab