From 7be33cc6f0b5438b37aef61babb4b12e271a8473 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Gaya?= <sebastien.gaya@gmail.com>
Date: Mon, 9 May 2022 10:19:51 +0200
Subject: [PATCH] simple form error notification

---
 app/views/admin/communication/blocks/edit.html.erb            | 3 +++
 app/views/admin/communication/blocks/new.html.erb             | 3 +++
 app/views/admin/communication/extranets/_form.html.erb        | 3 +++
 .../admin/communication/website/categories/_form.html.erb     | 3 +++
 .../admin/communication/website/menu/items/_form.html.erb     | 3 +++
 app/views/admin/communication/website/menus/_form.html.erb    | 3 +++
 app/views/admin/communication/website/pages/_form.html.erb    | 3 +++
 app/views/admin/communication/website/posts/_form.html.erb    | 3 +++
 .../admin/communication/website/posts/curations/new.html.erb  | 2 ++
 app/views/admin/communication/websites/_form.html.erb         | 3 +++
 app/views/admin/education/program/roles/_form.html.erb        | 3 +++
 app/views/admin/education/program/teachers/_form.html.erb     | 3 +++
 app/views/admin/education/programs/_form.html.erb             | 3 +++
 app/views/admin/education/school/roles/_form.html.erb         | 2 ++
 app/views/admin/education/schools/_form.html.erb              | 3 +++
 app/views/admin/education/teachers/edit.html.erb              | 4 +++-
 app/views/admin/research/journal/articles/_form.html.erb      | 3 +++
 app/views/admin/research/journal/volumes/_form.html.erb       | 3 +++
 app/views/admin/research/journals/_form.html.erb              | 3 +++
 app/views/admin/research/laboratories/_form.html.erb          | 3 +++
 app/views/admin/research/laboratory/axes/_form.html.erb       | 3 +++
 app/views/admin/research/theses/_form.html.erb                | 3 +++
 app/views/admin/university/organization/imports/new.html.erb  | 3 +++
 app/views/admin/university/organizations/_form.html.erb       | 3 +++
 app/views/admin/university/people/_form.html.erb              | 3 +++
 .../admin/university/person/alumnus/imports/new.html.erb      | 3 +++
 app/views/admin/users/_form.html.erb                          | 3 +++
 app/views/server/languages/_form.html.erb                     | 3 +++
 app/views/server/universities/_form.html.erb                  | 1 +
 29 files changed, 83 insertions(+), 1 deletion(-)

diff --git a/app/views/admin/communication/blocks/edit.html.erb b/app/views/admin/communication/blocks/edit.html.erb
index e126220a1..022705614 100644
--- a/app/views/admin/communication/blocks/edit.html.erb
+++ b/app/views/admin/communication/blocks/edit.html.erb
@@ -9,6 +9,9 @@
     <span class="sr-only"><%= t 'loading' %></span>
   </div>
   <%= simple_form_for [:admin, @block] do |f| %>
+    <%= f.error_notification %>
+    <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
     <div class="row">
       <div class="col-xxl-4 col-md-6">
         <%= f.input :title %>
diff --git a/app/views/admin/communication/blocks/new.html.erb b/app/views/admin/communication/blocks/new.html.erb
index a5f480989..7afbfc0c4 100644
--- a/app/views/admin/communication/blocks/new.html.erb
+++ b/app/views/admin/communication/blocks/new.html.erb
@@ -9,6 +9,9 @@
         <div class="card-body">
           <h5 class="card-title"><%= t "enums.communication.block.template_kind.#{template_kind}" %></h5>
           <%= simple_form_for [:admin, @block] do |f| %>
+            <%= f.error_notification %>
+            <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
             <%= f.input :about_type, as: :hidden %>
             <%= f.input :about_id, as: :hidden %>
             <%= f.input :template_kind, as: :hidden %>
diff --git a/app/views/admin/communication/extranets/_form.html.erb b/app/views/admin/communication/extranets/_form.html.erb
index c1d3e253a..0f75c225c 100644
--- a/app/views/admin/communication/extranets/_form.html.erb
+++ b/app/views/admin/communication/extranets/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, extranet] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-4">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/website/categories/_form.html.erb b/app/views/admin/communication/website/categories/_form.html.erb
index 39f92fdb0..e31341944 100644
--- a/app/views/admin/communication/website/categories/_form.html.erb
+++ b/app/views/admin/communication/website/categories/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, category] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/website/menu/items/_form.html.erb b/app/views/admin/communication/website/menu/items/_form.html.erb
index 4827a49ef..d83ae39dd 100644
--- a/app/views/admin/communication/website/menu/items/_form.html.erb
+++ b/app/views/admin/communication/website/menu/items/_form.html.erb
@@ -1,5 +1,8 @@
 <%= simple_form_for item, url: item.persisted?  ? [:admin, item, { menu_id: @menu.id }]
                                                 : admin_communication_website_menu_items_path(@menu) do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <%= f.input :parent_id, as: :hidden, wrapper: false %>
   <div class="card flex-fill w-100">
     <div class="card-header">
diff --git a/app/views/admin/communication/website/menus/_form.html.erb b/app/views/admin/communication/website/menus/_form.html.erb
index df77eedc3..6c9e59450 100644
--- a/app/views/admin/communication/website/menus/_form.html.erb
+++ b/app/views/admin/communication/website/menus/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, menu] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/website/pages/_form.html.erb b/app/views/admin/communication/website/pages/_form.html.erb
index 2b23cedda..fe48a44ef 100644
--- a/app/views/admin/communication/website/pages/_form.html.erb
+++ b/app/views/admin/communication/website/pages/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, page] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/website/posts/_form.html.erb b/app/views/admin/communication/website/posts/_form.html.erb
index 94e9fd770..bae891ad6 100644
--- a/app/views/admin/communication/website/posts/_form.html.erb
+++ b/app/views/admin/communication/website/posts/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, post] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/website/posts/curations/new.html.erb b/app/views/admin/communication/website/posts/curations/new.html.erb
index 027a6208a..12ca16ce0 100644
--- a/app/views/admin/communication/website/posts/curations/new.html.erb
+++ b/app/views/admin/communication/website/posts/curations/new.html.erb
@@ -1,6 +1,8 @@
 <% content_for :title, t('communication.website.posts.new_curation') %>
 
 <%= simple_form_for :curation, url: admin_communication_website_post_curations_path, html: { id: 'new_communication_website_post_curation' } do |f| %>
+  <%= f.error_notification %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/communication/websites/_form.html.erb b/app/views/admin/communication/websites/_form.html.erb
index bdba59546..99bbb9dd6 100644
--- a/app/views/admin/communication/websites/_form.html.erb
+++ b/app/views/admin/communication/websites/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, website] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-4">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/education/program/roles/_form.html.erb b/app/views/admin/education/program/roles/_form.html.erb
index 071666536..433ceb7b4 100644
--- a/app/views/admin/education/program/roles/_form.html.erb
+++ b/app/views/admin/education/program/roles/_form.html.erb
@@ -1,6 +1,9 @@
 <%= simple_form_for [:admin, role],
                     url: role.new_record? ? admin_education_program_roles_path(@program)
                                           : admin_education_program_role_path(role, { program_id: @program.id }) do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/education/program/teachers/_form.html.erb b/app/views/admin/education/program/teachers/_form.html.erb
index 08f8fcb78..c1c2a892d 100644
--- a/app/views/admin/education/program/teachers/_form.html.erb
+++ b/app/views/admin/education/program/teachers/_form.html.erb
@@ -1,6 +1,9 @@
 <%= simple_form_for [:admin, involvement],
                     url: involvement.new_record? ? admin_education_program_teachers_path(@program)
                                                  : admin_education_program_teacher_path(involvement, { program_id: @program.id }) do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="card flex-fill w-100">
     <div class="card-header">
       <h5 class="card-title mb-0"><%= t('admin.infos') %></h5>
diff --git a/app/views/admin/education/programs/_form.html.erb b/app/views/admin/education/programs/_form.html.erb
index b6cab4099..a44339e3b 100644
--- a/app/views/admin/education/programs/_form.html.erb
+++ b/app/views/admin/education/programs/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, program] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-3">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/education/school/roles/_form.html.erb b/app/views/admin/education/school/roles/_form.html.erb
index effcbf968..5fe08980a 100644
--- a/app/views/admin/education/school/roles/_form.html.erb
+++ b/app/views/admin/education/school/roles/_form.html.erb
@@ -1,6 +1,8 @@
 <%= simple_form_for [:admin, role],
                     url: role.new_record? ? admin_education_school_roles_path(@school)
                                           : admin_education_school_role_path(role, { school_id: @school.id }) do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
 
   <div class="row">
     <div class="col-md-8">
diff --git a/app/views/admin/education/schools/_form.html.erb b/app/views/admin/education/schools/_form.html.erb
index 57b962753..57f400b31 100644
--- a/app/views/admin/education/schools/_form.html.erb
+++ b/app/views/admin/education/schools/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, school] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-6">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/education/teachers/edit.html.erb b/app/views/admin/education/teachers/edit.html.erb
index ade84d913..68677371f 100644
--- a/app/views/admin/education/teachers/edit.html.erb
+++ b/app/views/admin/education/teachers/edit.html.erb
@@ -3,7 +3,9 @@
 <h2 class="h3"><%= Education::Program.model_name.human(count: 2) %></h2>
 
 <%= simple_form_for [:admin, @teacher], url: admin_education_teacher_path(@teacher) do |f| %>
-<div class="row">
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %><div class="row">
+
   <div class="col-md-2">
     <%= link_to_add_association t('add'), f, :involvements,
                                 class: button_classes,
diff --git a/app/views/admin/research/journal/articles/_form.html.erb b/app/views/admin/research/journal/articles/_form.html.erb
index 741b225ea..4c93bbfe3 100644
--- a/app/views/admin/research/journal/articles/_form.html.erb
+++ b/app/views/admin/research/journal/articles/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, article] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/research/journal/volumes/_form.html.erb b/app/views/admin/research/journal/volumes/_form.html.erb
index 434978164..fa9e56696 100644
--- a/app/views/admin/research/journal/volumes/_form.html.erb
+++ b/app/views/admin/research/journal/volumes/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, volume] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/research/journals/_form.html.erb b/app/views/admin/research/journals/_form.html.erb
index c5b2761b3..d8c98a3af 100644
--- a/app/views/admin/research/journals/_form.html.erb
+++ b/app/views/admin/research/journals/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, journal] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-6">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/research/laboratories/_form.html.erb b/app/views/admin/research/laboratories/_form.html.erb
index b9471761b..c1b127b75 100644
--- a/app/views/admin/research/laboratories/_form.html.erb
+++ b/app/views/admin/research/laboratories/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, laboratory] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-6">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/research/laboratory/axes/_form.html.erb b/app/views/admin/research/laboratory/axes/_form.html.erb
index 542cdad8c..409265d9f 100644
--- a/app/views/admin/research/laboratory/axes/_form.html.erb
+++ b/app/views/admin/research/laboratory/axes/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, axis] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/research/theses/_form.html.erb b/app/views/admin/research/theses/_form.html.erb
index 917479959..977be86af 100644
--- a/app/views/admin/research/theses/_form.html.erb
+++ b/app/views/admin/research/theses/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, thesis] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-6">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/university/organization/imports/new.html.erb b/app/views/admin/university/organization/imports/new.html.erb
index 9199ac8ab..18e5d067f 100644
--- a/app/views/admin/university/organization/imports/new.html.erb
+++ b/app/views/admin/university/organization/imports/new.html.erb
@@ -11,6 +11,9 @@
       Les valeurs possibles pour kind sont : company, non_profit, government.
     </p>
     <%= simple_form_for [:admin, @import] do |f| %>
+      <%= f.error_notification %>
+      <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
       <%= f.input :file %>
       <% content_for :action_bar_right do %>
         <%= submit f %>
diff --git a/app/views/admin/university/organizations/_form.html.erb b/app/views/admin/university/organizations/_form.html.erb
index 5903d409c..fefe6be26 100644
--- a/app/views/admin/university/organizations/_form.html.erb
+++ b/app/views/admin/university/organizations/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, organization] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/university/people/_form.html.erb b/app/views/admin/university/people/_form.html.erb
index 1c82d2d18..6ba4c1232 100644
--- a/app/views/admin/university/people/_form.html.erb
+++ b/app/views/admin/university/people/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, person] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <div class="card flex-fill w-100">
diff --git a/app/views/admin/university/person/alumnus/imports/new.html.erb b/app/views/admin/university/person/alumnus/imports/new.html.erb
index 78665920c..dfdf89c5e 100644
--- a/app/views/admin/university/person/alumnus/imports/new.html.erb
+++ b/app/views/admin/university/person/alumnus/imports/new.html.erb
@@ -11,6 +11,9 @@
       Les valeurs pour gender peuvent être m (masculin), f (féminin) et n (non binaire).
     </p>
     <%= simple_form_for [:admin, @import] do |f| %>
+      <%= f.error_notification %>
+      <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
       <%= f.input :file %>
       <% content_for :action_bar_right do %>
         <%= submit f %>
diff --git a/app/views/admin/users/_form.html.erb b/app/views/admin/users/_form.html.erb
index c2e732e90..5d7b002bf 100644
--- a/app/views/admin/users/_form.html.erb
+++ b/app/views/admin/users/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:admin, user] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-4">
       <div class="card flex-fill w-100">
diff --git a/app/views/server/languages/_form.html.erb b/app/views/server/languages/_form.html.erb
index 480d192ef..4284d412e 100644
--- a/app/views/server/languages/_form.html.erb
+++ b/app/views/server/languages/_form.html.erb
@@ -1,4 +1,7 @@
 <%= simple_form_for [:server, language] do |f| %>
+  <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
+
   <div class="row">
     <div class="col-md-8">
       <%= f.input :name %>
diff --git a/app/views/server/universities/_form.html.erb b/app/views/server/universities/_form.html.erb
index 480d423f6..3defd9c1e 100644
--- a/app/views/server/universities/_form.html.erb
+++ b/app/views/server/universities/_form.html.erb
@@ -1,5 +1,6 @@
 <%= simple_form_for [:server, university] do |f| %>
   <%= f.error_notification %>
+  <%= f.error_notification message: f.object.errors[:base].to_sentence if f.object.errors[:base].present? %>
 
   <div class="row">
     <div class="col-md-4">
-- 
GitLab