From 90c5d2d0f7c9a25f413f7c9446cc328903428600 Mon Sep 17 00:00:00 2001
From: Arnaud Levy <contact@arnaudlevy.com>
Date: Tue, 21 Sep 2021 19:24:23 +0200
Subject: [PATCH] After commit to allow creation for newly updated files
---
app/models/research/journal/article.rb | 2 +-
app/models/research/journal/volume.rb | 2 +-
.../admin/research/journal/articles/show.html.erb | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/app/models/research/journal/article.rb b/app/models/research/journal/article.rb
index bcdb5bba8..20a415c65 100644
--- a/app/models/research/journal/article.rb
+++ b/app/models/research/journal/article.rb
@@ -37,7 +37,7 @@ class Research::Journal::Article < ApplicationRecord
belongs_to :updated_by, class_name: 'User'
has_and_belongs_to_many :researchers, class_name: 'Research::Researcher'
- after_save :publish_to_github
+ after_commit :publish_to_github
has_one_attached :pdf
diff --git a/app/models/research/journal/volume.rb b/app/models/research/journal/volume.rb
index b8521454e..86e614af0 100644
--- a/app/models/research/journal/volume.rb
+++ b/app/models/research/journal/volume.rb
@@ -28,7 +28,7 @@ class Research::Journal::Volume < ApplicationRecord
belongs_to :journal, foreign_key: :research_journal_id
has_many :articles, foreign_key: :research_journal_volume_id
- after_save :publish_to_github
+ after_commit :publish_to_github
has_one_attached :cover
diff --git a/app/views/admin/research/journal/articles/show.html.erb b/app/views/admin/research/journal/articles/show.html.erb
index 6814e480f..e143915f9 100644
--- a/app/views/admin/research/journal/articles/show.html.erb
+++ b/app/views/admin/research/journal/articles/show.html.erb
@@ -26,12 +26,12 @@
<h5 class="card-title mb-0">Metadata</h5>
</div>
<div class="card-body">
- <h3 class="h5"><%= Research::Journal::Article.human_attribute_name('published_at') %></h3>
+ <h3 class="h5"><%= Research::Journal::Article.human_attribute_name('volume') %></h3>
+ <%= link_to @article.volume, [:admin, @article.volume] if @article.volume %>
+ <h3 class="h5 mt-4"><%= Research::Journal::Article.human_attribute_name('published_at') %></h3>
<p><%= @article.published_at&.to_date %></p>
- <% if @article.volume %>
- <h3 class="h5 mt-4"><%= Research::Journal::Article.human_attribute_name('researchers') %></h3>
- <%= link_to @article.volume, [:admin, @article.volume] %>
- <% end %>
+ <h3 class="h5 mt-4"><%= Research::Journal::Article.human_attribute_name('keywords') %></h3>
+ <p><%= @article.keywords %></p>
<h3 class="h5 mt-4"><%= Research::Journal::Article.human_attribute_name('researchers') %></h3>
<ul class="list-unstyled">
<% @article.researchers.each do |researcher| %>
--
GitLab