From 5badf5266de4ae645e05d2a5b666b6490d79d8c8 Mon Sep 17 00:00:00 2001
From: alexisben <alex@noesya.coop>
Date: Mon, 23 Jan 2023 12:14:48 +0100
Subject: [PATCH] heading check
---
assets/sass/_theme/blocks/base.sass | 4 +++-
assets/sass/_theme/blocks/pages.sass | 6 +++---
assets/sass/_theme/blocks/timeline.sass | 3 ++-
assets/sass/_theme/sections/organizations.sass | 2 +-
assets/sass/_theme/sections/posts.sass | 4 ++--
assets/sass/_theme/sections/programs.sass | 6 ++++--
layouts/partials/blocks/templates/image.html | 4 +++-
layouts/partials/blocks/templates/partners.html | 4 ++--
layouts/partials/blocks/templates/timeline/vertical.html | 2 +-
layouts/partials/organizations/organization.html | 2 +-
layouts/partials/programs/program.html | 4 ++--
11 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/assets/sass/_theme/blocks/base.sass b/assets/sass/_theme/blocks/base.sass
index 26694794..67aa545c 100644
--- a/assets/sass/_theme/blocks/base.sass
+++ b/assets/sass/_theme/blocks/base.sass
@@ -12,7 +12,9 @@
.top
h2, h3
+ .description
- margin-top: $spacing2
+ margin-top: $spacing1
+ @include media-breakpoint-up(desktop)
+ margin-top: $spacing2
// Specific
$backgrounded_blocks: ".block-call_to_action, .block-chapter--accent_background, .block-chapter--alt_background, .block-timeline--horizontal, .block-pages--cards"
diff --git a/assets/sass/_theme/blocks/pages.sass b/assets/sass/_theme/blocks/pages.sass
index 9ef5f3a5..53298a0a 100644
--- a/assets/sass/_theme/blocks/pages.sass
+++ b/assets/sass/_theme/blocks/pages.sass
@@ -19,7 +19,7 @@
aspect-ratio: 16/9
object-fit: cover
width: 100%
- h1
+ h3
@include h3
a
text-decoration: none
@@ -33,7 +33,7 @@
@include media-breakpoint-down(desktop)
.top
- h2, h3
+ h2
@include h5
.description
@include h2
@@ -44,7 +44,7 @@
@include media-breakpoint-up(desktop)
.top
@include grid
- h2, h3
+ h2
grid-column: 1 / 5
a
text-decoration: none
diff --git a/assets/sass/_theme/blocks/timeline.sass b/assets/sass/_theme/blocks/timeline.sass
index 472ef37d..1197ee05 100644
--- a/assets/sass/_theme/blocks/timeline.sass
+++ b/assets/sass/_theme/blocks/timeline.sass
@@ -111,8 +111,9 @@
width: 50%
.title
+ display: block
min-height: var(--min-title-height)
- margin-bottom: $spacing1
+ padding-bottom: $spacing1
@include signature
.description
@include small
diff --git a/assets/sass/_theme/sections/organizations.sass b/assets/sass/_theme/sections/organizations.sass
index 0c080965..19b8db69 100644
--- a/assets/sass/_theme/sections/organizations.sass
+++ b/assets/sass/_theme/sections/organizations.sass
@@ -1,7 +1,7 @@
.organization
@include article
position: relative
- h1
+ h2
@include meta
a
@include stretched-link
diff --git a/assets/sass/_theme/sections/posts.sass b/assets/sass/_theme/sections/posts.sass
index 352fdb7e..cbf241a8 100644
--- a/assets/sass/_theme/sections/posts.sass
+++ b/assets/sass/_theme/sections/posts.sass
@@ -28,7 +28,7 @@
margin-bottom: $spacing1
padding-bottom: $spacing1
flex-direction: row
- h1 + p
+ h2 + p, h3 + p
margin-top: $spacing0
@include media-breakpoint-up(desktop)
@include grid
@@ -58,7 +58,7 @@
right: 0
top: 0
div:not(.media)
- h1, h2, h3,
+ h2, h3,
p
max-width: col(6, 9)
.posts--grid
diff --git a/assets/sass/_theme/sections/programs.sass b/assets/sass/_theme/sections/programs.sass
index f3fc2944..cee27438 100644
--- a/assets/sass/_theme/sections/programs.sass
+++ b/assets/sass/_theme/sections/programs.sass
@@ -103,11 +103,13 @@ ol.programs
.blocks
section > * + *
margin-top: 0
- h3
+ h2
@include h3
@include media-breakpoint-down(desktop)
+ padding-top: $spacing3
margin-left: half(-$grid-gutter-sm)
margin-right: half(-$grid-gutter-sm)
+
@include media-breakpoint-up(desktop)
.container
padding-left: 0
@@ -117,7 +119,7 @@ ol.programs
@include media-breakpoint-down(desktop)
.document-content
.content
- h2
+ > h2
margin-bottom: $spacing2
section:not(:first-child):not(.block)
margin-top: $spacing3
diff --git a/layouts/partials/blocks/templates/image.html b/layouts/partials/blocks/templates/image.html
index a43230f2..2bc4ef56 100644
--- a/layouts/partials/blocks/templates/image.html
+++ b/layouts/partials/blocks/templates/image.html
@@ -14,7 +14,9 @@
{{- if not $title -}}
{{ partial "blocks/default_title.html" $template }}
{{ else }}
- <h2>{{ partial "PrepareHTML" $title }}</h2>
+ <div class="top">
+ <h2>{{ partial "PrepareHTML" $title }}</h2>
+ </div>
{{ end -}}
{{- with .image -}}
diff --git a/layouts/partials/blocks/templates/partners.html b/layouts/partials/blocks/templates/partners.html
index 21c3c954..20ce1f6c 100644
--- a/layouts/partials/blocks/templates/partners.html
+++ b/layouts/partials/blocks/templates/partners.html
@@ -33,7 +33,7 @@
{{ if .name }}
<div>
{{ $title = partial "PrepareHTML" .name -}}
- <h1>
+ <h3>
{{- if .url }}
<a href="{{ .url }}" title="{{ safeHTML (i18n "commons.link.blank_aria" (dict "Title" $title)) }}">
{{ end }}
@@ -41,7 +41,7 @@
{{ if .url }}
</a>
{{ end -}}
- </h1>
+ </h3>
</div>
{{ end -}}
<div class="media">
diff --git a/layouts/partials/blocks/templates/timeline/vertical.html b/layouts/partials/blocks/templates/timeline/vertical.html
index f8205582..0d465e69 100644
--- a/layouts/partials/blocks/templates/timeline/vertical.html
+++ b/layouts/partials/blocks/templates/timeline/vertical.html
@@ -12,7 +12,7 @@
{{ range .events -}}
<article class="event">
{{ if .title }}
- <h1 class="event-title">{{ partial "PrepareHTML" .title }}</h1>
+ <h3 class="event-title">{{ partial "PrepareHTML" .title }}</h3>
{{ end }}
{{ if .text }}
<p>{{ partial "PrepareText" .text }}</p>
diff --git a/layouts/partials/organizations/organization.html b/layouts/partials/organizations/organization.html
index e434c3d8..a82c6cc2 100644
--- a/layouts/partials/organizations/organization.html
+++ b/layouts/partials/organizations/organization.html
@@ -1,7 +1,7 @@
<article class="organization">
<div>
{{ $title := partial "PrepareHTML" .Title }}
- <h1><a href="{{ .Permalink }}" title="{{ safeHTML (i18n "commons.more_aria" (dict "Title" $title)) }}">{{ $title }}</a></h1>
+ <h2><a href="{{ .Permalink }}" title="{{ safeHTML (i18n "commons.more_aria" (dict "Title" $title)) }}">{{ $title }}</a></h2>
</div>
<div class="media">
{{- if .Params.logo -}}
diff --git a/layouts/partials/programs/program.html b/layouts/partials/programs/program.html
index 45e78043..caa4fd80 100644
--- a/layouts/partials/programs/program.html
+++ b/layouts/partials/programs/program.html
@@ -1,11 +1,11 @@
{{- $title := partial "PrepareHTML" .Title -}}
<article class="program">
<div>
- <h1>
+ <h2>
<a href="{{ .Permalink }}" title="{{ safeHTML (i18n "commons.more_aria" (dict "Title" $title)) }}">
{{- $title -}}
</a>
- </h1>
+ </h2>
{{ if (partial "GetTextFromHTML" .Params.presentation) }}
<p>{{- partial "PrepareHTML" .Params.presentation -}}</p>
{{ end }}
--
GitLab