From f87209ce96c8d89cec607d312aad20307398eb76 Mon Sep 17 00:00:00 2001
From: alexisben <alex@noesya.coop>
Date: Thu, 15 Dec 2022 11:03:57 +0100
Subject: [PATCH] remove useless variables
---
assets/sass/_theme/_configuration.sass | 4 ----
assets/sass/_theme/_utils.sass | 6 +++---
assets/sass/_theme/design-system/typography.sass | 2 +-
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/assets/sass/_theme/_configuration.sass b/assets/sass/_theme/_configuration.sass
index 01f1689d..f68ac512 100644
--- a/assets/sass/_theme/_configuration.sass
+++ b/assets/sass/_theme/_configuration.sass
@@ -16,10 +16,6 @@ $link-color: $color-text !default
$body-font-family: "Baskerville", "Times New Roman", "Times", serif !default
$heading-font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif !default
-// Base
-$font-size-base: 16px !default
-$line-height-base: 160% !default
-
// Headings
$heading-font-weight: normal !default
diff --git a/assets/sass/_theme/_utils.sass b/assets/sass/_theme/_utils.sass
index 89dcfdf3..a39abaab 100644
--- a/assets/sass/_theme/_utils.sass
+++ b/assets/sass/_theme/_utils.sass
@@ -212,7 +212,7 @@
@include arrow-right-hover
display: block
&::after
- font-size: $font-size-base
+ font-size: px2rem(16)
transform: translateX(0)
position: relative
&:hover
@@ -277,7 +277,7 @@
@mixin button-icon($icon: false)
@include button-reset
- line-height: $line-height-base
+ line-height: $body-line-height
border: 1px solid $hero-color
padding: $spacing0 $spacing1
white-space: nowrap
@@ -299,7 +299,7 @@
display: flex
justify-content: space-between
align-items: center
- @include icon("arrow-right", after, $small-size)
+ @include icon("arrow-right", after, $small-size)
opacity: 0
transform: translateX(-20px)
transition: 0.55s $arrow-ease-transition
diff --git a/assets/sass/_theme/design-system/typography.sass b/assets/sass/_theme/design-system/typography.sass
index 6351b29b..52796a75 100644
--- a/assets/sass/_theme/design-system/typography.sass
+++ b/assets/sass/_theme/design-system/typography.sass
@@ -7,7 +7,7 @@ body
font-size: $body-size
font-variant-ligatures: common-ligatures
text-rendering: optimizelegibility
- line-height: $line-height-base
+ line-height: $body-line-height
word-break: break-word
@include media-breakpoint-up(md)
font-size: $body-size-md
--
GitLab