country label + tests

app/services/contact_details/country.rb

@@ -3,8 +3,7 @@ class ContactDetails::Country < ContactDetails::Base
   protected
 
   def prepare_label
-    super
-    # TODO country name
+    @label = ISO3166::Country[@string].common_name
   end
 
 end
\ No newline at end of file

test/services/contact_details_test.rb

@@ -4,68 +4,68 @@ class ContactDetailsTest < ActiveSupport::TestCase
 
   test "country nil" do
     detail = ContactDetails::Country.new nil
-    assert_equal detail.label, ''
-    assert_equal detail.url, ''
+    assert_nil detail.label
+    assert_nil detail.url
   end
 
   test "country FR" do
     detail = ContactDetails::Country.new 'FR'
-    assert_equal detail.label, 'France'
-    assert_equal detail.url, 'FR'
+    assert_equal 'France', detail.label
+    assert_equal 'FR', detail.url
   end
 
   test "email nil" do
     detail = ContactDetails::Email.new nil
-    assert_equal detail.label, ''
-    assert_equal detail.url, ''
+    assert_nil detail.label
+    assert_nil detail.url
   end
 
   test "email arnaud.levy@noesya.coop" do
     detail = ContactDetails::Email.new 'arnaud.levy@noesya.coop'
-    assert_equal detail.label, 'arnaud.levy@noesya.coop'
-    assert_equal detail.url, 'mailto:arnaud.levy@noesya.coop'
+    assert_equal 'arnaud.levy@noesya.coop', detail.label
+    assert_equal 'mailto:arnaud.levy@noesya.coop', detail.url
   end
 
   test "twitter nil" do
     detail = ContactDetails::Twitter.new nil
-    assert_equal detail.label, ''
-    assert_equal detail.url, ''
+    assert_nil detail.label
+    assert_nil detail.url
   end
 
   test "twitter handle" do
     detail = ContactDetails::Twitter.new 'arnaudlevy'
-    assert_equal detail.label, 'arnaudlevy'
-    assert_equal detail.url, 'https://twitter.com/arnaudlevy'
+    assert_equal 'arnaudlevy', detail.label
+    assert_equal 'https://twitter.com/arnaudlevy', detail.url
   end
 
   test "twitter twitter.com/arnaudlevy" do
     detail = ContactDetails::Twitter.new 'twitter.com/arnaudlevy'
-    assert_equal detail.label, 'arnaudlevy'
-    assert_equal detail.url, 'https://twitter.com/arnaudlevy'
+    assert_equal 'arnaudlevy', detail.label
+    assert_equal 'https://twitter.com/arnaudlevy', detail.url
   end
 
   test "twitter https://twitter.com/arnaudlevy" do
     detail = ContactDetails::Twitter.new 'https://twitter.com/arnaudlevy'
-    assert_equal detail.label, 'arnaudlevy'
-    assert_equal detail.url, 'https://twitter.com/arnaudlevy'
+    assert_equal 'arnaudlevy', detail.label
+    assert_equal 'https://twitter.com/arnaudlevy', detail.url
   end
 
   test "website nil" do
     detail = ContactDetails::Website.new nil
-    assert_equal detail.label, ''
-    assert_equal detail.url, ''
+    assert_nil detail.label
+    assert_nil detail.url
   end
 
   test "website www.noesya.coop" do
     detail = ContactDetails::Website.new 'www.noesya.coop'
-    assert_equal detail.label, 'www.noesya.coop'
-    assert_equal detail.url, 'https://www.noesya.coop'
+    assert_equal 'www.noesya.coop', detail.label
+    assert_equal 'https://www.noesya.coop', detail.url
   end
 
   test "website https://www.noesya.coop" do
     detail = ContactDetails::Website.new 'https://www.noesya.coop'
-    assert_equal detail.label, 'www.noesya.coop'
-    assert_equal detail.url, 'https://www.noesya.coop'
+    assert_equal 'www.noesya.coop', detail.label
+    assert_equal 'https://www.noesya.coop', detail.url
   end
 
 end
\ No newline at end of file