refactor

app/controllers/api/osuny/server/websites_controller.rb

@@ -5,9 +5,10 @@ class Api::Osuny::Server::WebsitesController < Api::ApplicationController
   end
 
   def theme_released
-    render_forbidden unless params[:secret_key].present? && params[:secret_key] == ENV['OSUNY_API_AUTOUPDATE_THEME_KEY']
-    Communication::Website.with_automatic_update.find_each do |website|
-      website.update_theme_version
+    if params[:secret_key].present? && params[:secret_key] == ENV['OSUNY_API_AUTOUPDATE_THEME_KEY']
+      Communication::Website.autoupdate_websites
+    else
+      render_forbidden 
     end
   end
 end

app/models/communication/website/with_theme.rb

@@ -4,8 +4,15 @@ module Communication::Website::WithTheme
   included do
     scope :with_automatic_update, -> { where(autoupdate_theme: true) }
     scope :with_manual_update, -> { where(autoupdate_theme: false) }
+
+    def self.autoupdate_websites
+      Communication::Website.with_automatic_update.find_each do |website|
+        website.update_theme_version
+      end
+    end
   end
 
+
   def get_current_theme_version!
     self.update_column :theme_version, current_theme_version
   end