wip variant service test

app/services/variant_service.rb

@@ -42,7 +42,7 @@ class VariantService
         dimensions = blob_size
       end
       dimensions.map! { |dimension| dimension * params[:scale].to_i if dimension.is_a?(Integer) } if params[:scale].present?
-      2.times { |i| dimensions[i] = [dimensions[i], blob_size[i]].min unless dimensions[i].nil? }
+      # 2.times { |i| dimensions[i] = [dimensions[i], blob_size[i]].min unless dimensions[i].nil? }
 
       # Resize and/or crop unless original size
       unless dimensions == blob_size

test/models/variant_service_test.rb

@@ -31,6 +31,7 @@ class VariantServiceTest < ActiveSupport::TestCase
   # dan-gold_200x300_crop_top.jpeg
   # dan-gold_300x200_crop_right@2x.jpeg
   # dan-gold_1000x500_crop_left.jpeg
+  # dan-gold_500x500_crop_left@2x.jpeg
 
   # Params tests
 
@@ -141,6 +142,13 @@ class VariantServiceTest < ActiveSupport::TestCase
     assert_equal expected_params, variant_service.params
   end
 
+  test "params for dan-gold_500x500_crop_left@2x.jpeg" do
+    blob = create_file_blob(filename: "dan-gold.jpeg")
+    expected_params = { size: '500x500', gravity: 'West', scale: 2 }
+    variant_service = VariantService.compute(blob, 'dan-gold_500x500_crop_left@2x', 'jpeg')
+    assert_equal expected_params, variant_service.params
+  end
+
   # Transformations tests
 
   test "transformations for dan-gold.jpeg" do
@@ -263,6 +271,16 @@ class VariantServiceTest < ActiveSupport::TestCase
     assert_equal expected_transformations, variant_service.transformations
   end
 
+  # test "transformations for dan-gold_500x500_crop_left@2x.jpeg" do
+  #   blob = create_file_blob(filename: "dan-gold.jpeg")
+  #   expected_transformations = {
+  #     resize_to_fill: [1000, 1000, { gravity: 'West' }, scale: 2],
+  #     crop: '1000x1000+0+0'
+  #   }
+  #   variant_service = VariantService.compute(blob, 'dan-gold_500x500_crop_left@2x', 'jpeg')
+  #   assert_equal expected_transformations, variant_service.transformations
+  # end
+
   # Variants tests
 
   test "variant for dan-gold.webp" do
@@ -350,6 +368,12 @@ class VariantServiceTest < ActiveSupport::TestCase
     assert_equal expected_blob.checksum, image_checksum(image)
   end
 
+  # test "variant for dan-gold_500x500_crop_left@2x.jpeg" do
+  #   expected_blob = create_file_blob(filename: "dan-gold_500x500_crop_left@2x.jpeg")
+  #   image = load_image_from_variant_name(expected_blob.filename.base)
+  #   assert_equal expected_blob.checksum, image_checksum(image)
+  # end
+
   private
 
   def create_file_blob(key: nil, filename: "dan-gold.jpeg", content_type: "image/jpeg", metadata: nil, service_name: nil, record: nil)