edit about

app/assets/javascripts/admin/communication/menu_items.js

@@ -9,27 +9,45 @@ window.osuny.communication.menuItems = {
         this.elementsForKindUrl = document.querySelectorAll('.kind-url');
         this.requiredInputsForKindUrl = document.querySelectorAll('.kind-url .form-group.required select, .kind-url .form-group.required input');
 
+        this.elementsForKindPage = document.querySelectorAll('.kind-page');
+        this.requiredInputsForKindPage = document.querySelectorAll('.kind-page .form-group.required select, .kind-page .form-group.required input');
+
         this.kindInput.addEventListener('change', this.onKindChange.bind(this));
         this.onKindChange();
     },
 
     onKindChange: function () {
         'use strict';
-        var kind = this.kindInput.value,
-            i;
-        for (i = 0; i < this.elementsForKindUrl.length; i += 1) {
-            if (kind === 'url') {
-                this.elementsForKindUrl[i].classList.remove('d-none');
-            } else {
-                this.elementsForKindUrl[i].classList.add('d-none');
-            }
+        var kind = this.kindInput.value;
+
+        if (kind === 'url') {
+            this.showElements(this.elementsForKindUrl, this.requiredInputsForKindUrl);
+            this.hideElements(this.elementsForKindPage, this.requiredInputsForKindPage);
+        } else {
+            this.showElements(this.elementsForKindPage, this.requiredInputsForKindPage);
+            this.hideElements(this.elementsForKindUrl, this.requiredInputsForKindUrl);
+        }
+    },
+
+    showElements: function (elements, requiredInputs) {
+        'use strict';
+        var i;
+        for (i = 0; i < elements.length; i += 1) {
+            elements[i].classList.remove('d-none');
+        }
+        for (i = 0; i < requiredInputs.length; i += 1) {
+            requiredInputs[i].setAttribute('required', 'required');
+        }
+    },
+
+    hideElements: function (elements, requiredInputs) {
+        'use strict';
+        var i;
+        for (i = 0; i < elements.length; i += 1) {
+            elements[i].classList.add('d-none');
         }
-        for (i = 0; i < this.requiredInputsForKindUrl.length; i += 1) {
-            if (kind === 'url') {
-                this.requiredInputsForKindUrl[i].setAttribute('required', 'required');
-            } else {
-                this.requiredInputsForKindUrl[i].removeAttribute('required');
-            }
+        for (i = 0; i < requiredInputs.length; i += 1) {
+            requiredInputs[i].removeAttribute('required');
         }
     },
 

app/controllers/admin/communication/website/menu/items_controller.rb

@@ -78,7 +78,7 @@ class Admin::Communication::Website::Menu::ItemsController < Admin::Communicatio
 
   def item_params
     params.require(:communication_website_menu_item)
-          .permit(:title, :kind, :url, :parent_id)
+          .permit(:title, :kind, :url, :parent_id, :about_type, :about_id)
           .merge(university_id: current_university.id)
   end
 end

app/views/admin/communication/website/menu/items/_form.html.erb

@@ -12,6 +12,10 @@
           <div class="kind-url">
             <%= f.input :url, as: :string %>
           </div>
+          <div class="kind-page">
+            <%= f.input :about_type, as: :hidden, input_html: { value: 'Communication::Website::Page' } %>
+            <%= f.association :about, collection: @website.pages.ordered %>
+          </div>
         </div>
       </div>
     </div>

app/views/admin/communication/website/menu/items/show.html.erb

@@ -12,6 +12,17 @@
             <td width="150"><%= Communication::Website::Menu::Item.human_attribute_name('kind') %></td>
             <td><%= @item.kind %></td>
           </tr>
+          <% if @item.kind_url? %>
+            <tr>
+              <td width="150"><%= Communication::Website::Menu::Item.human_attribute_name('url') %></td>
+              <td><%= link_to @item.url, @item.url, target: :blank unless @item.url.blank? %></td>
+            </tr>
+          <% else %>
+            <tr>
+              <td width="150"><%= Communication::Website::Menu::Item.human_attribute_name('about') %></td>
+              <td><%= link_to_if can?(:read, @item.about), @item.about, [:admin, @item.about] %></td>
+            </tr>
+          <% end %>
         </tbody>
       </table>
     </div>

config/locales/communication/fr.yml

@@ -77,6 +77,7 @@ fr:
         identifier: Identifiant
         title: Titre
       communication/website/menu/item:
+        about: Cible
         kind: Type
         parent: Élément parent
         title: Titre