clean

app/models/communication/website/imported/page.rb

@@ -49,7 +49,6 @@ class Communication::Website::Imported::Page < ApplicationRecord
              optional: true
 
   before_validation :sync
-  after_commit :sync_featured_image, on: [:create, :update]
 
   default_scope { order(:path) }
 
@@ -101,46 +100,4 @@ class Communication::Website::Imported::Page < ApplicationRecord
     chapter.data = chapter_data
     chapter.save
   end
-
-  def sync_featured_image
-    return unless ENV['APPLICATION_ENV'] == 'development' || updated_at > page.updated_at
-
-    if featured_medium.present?
-      sync_featured_image_from_featured_medium
-    else
-      sync_featured_image_from_content
-    end
-  end
-
-  def sync_featured_image_from_featured_medium
-    unless featured_medium.file.attached?
-      featured_medium.load_remote_file!
-      featured_medium.save
-    end
-    page.featured_image.attach(
-      io: URI.open(featured_medium.file.blob.url),
-      filename: featured_medium.file.blob.filename,
-      content_type: featured_medium.file.blob.content_type
-    )
-  end
-
-  def sync_featured_image_from_content
-    chapter = page.blocks.where(university: website.university, template_kind: :chapter).first_or_create
-    chapter_data = chapter.data.deep_dup
-    fragment = Nokogiri::HTML.fragment(chapter_data['text'].to_s)
-    image = fragment.css('img').first
-    if image.present?
-      begin
-        url = image.attr('src')
-        download_service = DownloadService.download(url)
-        page.featured_image.attach(download_service.attachable_data)
-        image.remove
-        chapter_data['text'] = fragment.to_html
-        chapter.data = chapter_data
-        chapter.save
-      rescue
-      end
-    end
-  end
-
 end

app/models/communication/website/imported/post.rb

@@ -38,18 +38,19 @@
 #
 class Communication::Website::Imported::Post < ApplicationRecord
   include WithUniversity
+  include Communication::Website::Imported::WithFeaturedImage
 
   belongs_to :website,
              class_name: 'Communication::Website::Imported::Website'
   belongs_to :post,
              class_name: 'Communication::Website::Post',
              optional: true
+  alias_attribute :generated_object, :post
   belongs_to :featured_medium,
              class_name: 'Communication::Website::Imported::Medium',
              optional: true
 
   before_validation :sync
-  after_commit :sync_featured_image, on: [:create, :update]
 
   default_scope { order(path: :desc) }
 
@@ -114,46 +115,4 @@ class Communication::Website::Imported::Post < ApplicationRecord
     chapter.save
   end
 
-  def sync_featured_image
-    return unless ENV['APPLICATION_ENV'] == 'development' || updated_at > post.updated_at
-
-    if featured_medium.present?
-      sync_featured_image_from_featured_medium
-    else
-      sync_featured_image_from_content
-    end
-  end
-
-  def sync_featured_image_from_featured_medium
-    unless featured_medium.file.attached?
-      featured_medium.load_remote_file!
-      featured_medium.save
-    end
-    post.featured_image.attach(
-      io: URI.open(featured_medium.file.blob.url),
-      filename: featured_medium.file.blob.filename,
-      content_type: featured_medium.file.blob.content_type
-    )
-  end
-
-  def sync_featured_image_from_content
-    chapter = post.blocks.where(university: website.university, template_kind: :chapter).first_or_create
-    chapter_data = chapter.data.deep_dup
-    fragment = Nokogiri::HTML.fragment(chapter_data['text'].to_s)
-    image = fragment.css('img').first
-    # If content has an image, we extract it as the featured image
-    if image.present?
-      begin
-        url = image.attr('src')
-        download_service = DownloadService.download(url)
-        post.featured_image.attach(download_service.attachable_data)
-        image.remove
-        chapter_data['text'] = fragment.to_html
-        chapter.data = chapter_data
-        chapter.save
-      rescue
-      end
-    end
-  end
-
 end

app/models/communication/website/imported/with_featured_image.rb

+module Communication::Website::Imported::WithFeaturedImage
+  extend ActiveSupport::Concern
+
+  included do
+    after_commit :sync_featured_image, on: [:create, :update]
+  end
+
+  def sync_featured_image
+    return unless ENV['APPLICATION_ENV'] == 'development' || updated_at > generated_object.updated_at
+
+    if featured_medium.present?
+      sync_featured_image_from_featured_medium
+    else
+      sync_featured_image_from_content
+    end
+  end
+
+  def sync_featured_image_from_featured_medium
+    unless featured_medium.file.attached?
+      featured_medium.load_remote_file!
+      featured_medium.save
+    end
+    generated_object.featured_image.attach(
+      io: URI.open(featured_medium.file.blob.url),
+      filename: featured_medium.file.blob.filename,
+      content_type: featured_medium.file.blob.content_type
+    )
+  end
+
+  def sync_featured_image_from_content
+    chapter = generated_object.blocks.where(university: website.university, template_kind: :chapter).first_or_create
+    chapter_data = chapter.data.deep_dup
+    fragment = Nokogiri::HTML.fragment(chapter_data['text'].to_s)
+    image = fragment.css('img').first
+    if image.present?
+      begin
+        url = image.attr('src')
+        download_service = DownloadService.download(url)
+        generated_object.featured_image.attach(download_service.attachable_data)
+        image.remove
+        chapter_data['text'] = fragment.to_html
+        chapter.data = chapter_data
+        chapter.save
+      rescue
+      end
+    end
+  end
+end
\ No newline at end of file